Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default clientError replies on reused connection (#4101) #4133

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix: default clientError replies on reused connection (#4101) #4133

merged 1 commit into from
Jul 12, 2022

Commits on Jul 12, 2022

  1. fix: default clientError replies on reused connection (fastify#4101) 

    When fastify server receives request with invalid url
in a reused connection, it closes the connection
instead of 400 Bad Request reply.

The closed connection is then propagated by load balancer (ALB)
as 502 error. This turns client errors into closely monitored
server errors.

`socket.bytesWritten` is never going to be 0 on reused connection.
    Branislav Katreniak committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    588f219 View commit details
    Browse the repository at this point in the history