Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove http2 experimental status (#4142) #4144

Merged
merged 1 commit into from Jul 18, 2022
Merged

docs: remove http2 experimental status (#4142) #4144

merged 1 commit into from Jul 18, 2022

Conversation

polyrainbow
Copy link
Contributor

Checklist

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 18, 2022
Comment on lines 5 to 7
_Fastify_ supports HTTP2 starting from Node 8 LTS,
which includes HTTP2 without a flag; HTTP2 is supported over either HTTPS or
plaintext.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Fastify_ supports HTTP2 starting from Node 8 LTS,
which includes HTTP2 without a flag; HTTP2 is supported over either HTTPS or
plaintext.
_Fastify_ supports HTTP2 over either HTTPS or plaintext (h2).

I would simplify the full sentence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifying sounds good. But don't you mean HTTPS (h2) or plaintext (h2c) instead?

i'm asking because the HTTP/2 spec states:

The string "h2" identifies the protocol where HTTP/2 uses Transport Layer Security (TLS) [TLS12].
The string "h2c" identifies the protocol where HTTP/2 is run over cleartext TCP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, I meant h2c.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 81a937a into fastify:main Jul 18, 2022
@polyrainbow polyrainbow deleted the docs/remove-http2-experimental-status branch July 18, 2022 10:31
@polyrainbow polyrainbow mentioned this pull request Jul 18, 2022
2 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants