Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove assert to invalid HTTP version #4260

Merged
merged 1 commit into from Sep 8, 2022
Merged

Conversation

RafaelGSS
Copy link
Member

This behaviour has changed on v18.9. It's now validating and returning 400 Bad Request.

For further information, see: nodejs/node#44344

@github-actions github-actions bot added the test Issue or pr related to our testing infrastructure. label Sep 8, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 91564f7 into main Sep 8, 2022
@mcollina mcollina deleted the RafaelGSS-patch-1 branch September 8, 2022 16:47
nooreldeensalah added a commit to nooreldeensalah/fastify that referenced this pull request Sep 8, 2022
* origin2/main:
  test: remove assert to invalid HTTP version (fastify#4260)
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test Issue or pr related to our testing infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants