Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests in Node.js v16 #4597

Merged
merged 8 commits into from
Feb 26, 2023
Merged

Fix tests in Node.js v16 #4597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
24ce60d
use node 18 for package manager ci
mcollina Feb 24, 2023
2af74dc
fixup
mcollina Feb 24, 2023
aba99cc
fixup
mcollina Feb 24, 2023
2521397
fixup
mcollina Feb 24, 2023
ade3e74
restore v14 and v16 in package manager ci
mcollina Feb 24, 2023
b4e8d84
fixup
mcollina Feb 24, 2023
ca4f400
fixup
mcollina Feb 26, 2023
3a835d6
fixup
mcollina Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/package-manager-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
matrix:
# Maintenance and active LTS
node-version: [14, 16]
node-version: [14, 16, 18]
os: [ubuntu-latest]

steps:
Expand Down Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
matrix:
# Maintenance and active LTS
node-version: [14, 16]
node-version: [14, 16, 18]
os: [ubuntu-latest]

steps:
Expand Down
18 changes: 10 additions & 8 deletions test/logger.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,17 @@ before(async function () {
[localhost, localhostForURL] = await helper.getLoopbackHost()
})

teardown(() => {
mcollina marked this conversation as resolved.
Show resolved Hide resolved
files.forEach((file) => {
try {
fs.unlinkSync(file)
} catch (e) {
console.log(e)
}
if (process.env.CI) {
teardown(() => {
files.forEach((file) => {
try {
fs.unlinkSync(file)
} catch (e) {
console.log(e)
}
})
})
})
}

test('defaults to info level', t => {
let fastify = null
Expand Down