Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missed symbol #4608

Merged
merged 2 commits into from
Mar 3, 2023
Merged

fix: add missed symbol #4608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e726a
fix: add missed symbol
metcoder95 Mar 3, 2023
aa5796c
trigger ci
metcoder95 Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/symbols.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const keys = {
kRequestValidateFns: Symbol('fastify.request.cache.validateFns'),
kRequestPayloadStream: Symbol('fastify.RequestPayloadStream'),
kRequestAcceptVersion: Symbol('fastify.RequestAcceptVersion'),
kRequestValidateWeakMap: Symbol('fastify.request.cache.validators'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding, was not expected to use kRequestValidateFns instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah you're right. I reacted too fast that I missed the other one.
I'll open a PR to clean up this, thanks for taking a second look 🙇

Thankfully the issue is solved, now just a matter of cleanup the mess

// 404
kFourOhFour: Symbol('fastify.404'),
kCanSetNotFoundHandler: Symbol('fastify.canSetNotFoundHandler'),
Expand Down