Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routeShortHandOptions type updated #4862

Closed

Conversation

gimnathperera
Copy link

@gimnathperera gimnathperera commented Jul 1, 2023

Changes

Checklist

  • run npm run test and npm run benchmark
Suites:   ​128 passed​, ​128 of 128 completed​
Asserts:  ​​​6990 passed​, ​4 skip​, ​of 6994​
| Stat    | 2.5%  | 50% | 97.5% | 99%  | Avg      | Stdev    | Max  |
|---------|-------|-----|-------|------|----------|----------|------|
| Latency | 4 ms  | 9 ms| 12 ms | 14 ms| 7.83 ms  | 2.86 ms  | 62 ms|

| Stat      | 1%     | 2.5%   | 50%    | 97.5%  | Avg       | Stdev    | Min    |
|-----------|--------|--------|--------|--------|-----------|----------|--------|
| Req/Sec   | 104383 | 104383 | 121087 | 125119 | 119889.07 | 4897.82  | 104352 |
| Bytes/Sec | 19.6MB | 19.6MB | 22.8MB | 23.5MB | 22.5MB    | 922kB    | 19.6MB |

@github-actions github-actions bot added the typescript TypeScript related label Jul 1, 2023
@Eomm
Copy link
Member

Eomm commented Jul 1, 2023

Would you mind to add a test here?

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say a NO here. It is the same as #4655 which cause regression of #4705

@gimnathperera
Copy link
Author

I would say a NO here. It is the same as #4655 which cause regression of #4705

So this change is not needed ??

@climba03003
Copy link
Member

climba03003 commented Jul 1, 2023

So this change is not needed ??

It is needed, but it should not cause the same regression mention above.
Please consider using different solution.

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 31, 2023

Closing due to inactivity.

@Uzlopak Uzlopak closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript TypeScript related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants