Support RouteShorthandOptions to Receive Async Hooks

[BrendenInhelder]

Checklist

• run npm run test and npm run benchmark

• tests and/or benchmarks are included

• documentation is changed or added

• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

• This PR addresses Support RouteShorthandOptions to receive async hooks #4859 for which a solution caused problems as seen in typings for the route config based hooks no longer working since 4.16.0 #4705 leading to respective revert fix: revert changes made to route hook types #4708. Through this PR, I hope to provide a solution that will avoid similar problems with typing.

• Instead of using OR ( | ) to solve the problem, I added extra variables to represent the async hook versions. In the previous attempt, I know the async versions were never called or recognized.

• I have changed the associated tests of RouteShorthandOptions to make use of the new async versions.

• I am not sure if this is the best way to address the issue, so I will mark this PR as a draft.
  Thanks for any feedback!

[Uzlopak]

Sry, but this is not valid.

[BrendenInhelder]

@Uzlopak Could you (or anyone else) explain further why my approach is incorrect? I believe you, I would just like to understand so I can attempt to solve the issue in another way.

[Uzlopak]

Because you are basically defining that the route short hand should contain async hooks in the corresponding hookNameAsync attributes.

[BrendenInhelder]

@Uzlopak Would you like me to continue working on this issue? It seems that #4945 may address this.

[Uzlopak]

#4945 is about handling correctly addHook() calls. but this one is about e.g. server.get() calls.

It doesnt seem to be trivial.

[BrendenInhelder]

@Uzlopak Thanks for the info. This issue bewilders me because even forcing a Promise as a return does not seem to match the call to use an async hook handler. I believe I will try working on something else.

[Uzlopak]

Lets discuss this more in #4859

[Uzlopak]

I close this for now, because there is no obvious way to solve it.