fix: errorHandler callback should utilize TypeProvider #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added typings tests |
Uzlopak
approved these changes
Aug 23, 2023
renovate bot
added a commit
to tomacheese/telcheck
that referenced
this pull request
Aug 27, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) #### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [fastify/fastify#4476 - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [fastify/fastify#4934 - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4929 - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4947 - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4951 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4952 - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4953 - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4954 - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [fastify/fastify#4948 - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [fastify/fastify#4956 - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4945 - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4963 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4973 - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [fastify/fastify#4969 - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4977 - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4979 - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4983 - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4982 - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4985 - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [fastify/fastify#4990 - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [fastify/fastify#4989 - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4968 - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4997 - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [fastify/fastify#4992 #### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [fastify/fastify#4948 - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [fastify/fastify#4990 - [@​muan](https://togithub.com/muan) made their first contribution in [fastify/fastify#4989 - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [fastify/fastify#4992 **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tomacheese/telcheck). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to redwoodjs/redwood
that referenced
this pull request
Aug 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) ##### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [fastify/fastify#4476 - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [fastify/fastify#4934 - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4929 - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4947 - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4951 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4952 - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4953 - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4954 - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [fastify/fastify#4948 - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [fastify/fastify#4956 - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4945 - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4963 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4973 - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [fastify/fastify#4969 - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4977 - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4979 - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4983 - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4982 - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4985 - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [fastify/fastify#4990 - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [fastify/fastify#4989 - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4968 - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4997 - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [fastify/fastify#4992 ##### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [fastify/fastify#4948 - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [fastify/fastify#4990 - [@​muan](https://togithub.com/muan) made their first contribution in [fastify/fastify#4989 - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [fastify/fastify#4992 **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
pushed a commit
to redwoodjs/redwood
that referenced
this pull request
Sep 2, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [fastify](https://www.fastify.io/) ([source](https://togithub.com/fastify/fastify)) | [`4.21.0` -> `4.22.0`](https://renovatebot.com/diffs/npm/fastify/4.21.0/4.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify (fastify)</summary> ### [`v4.22.0`](https://togithub.com/fastify/fastify/releases/tag/v4.22.0) [Compare Source](https://togithub.com/fastify/fastify/compare/v4.21.0...v4.22.0) ##### What's Changed - make FastifySchemaValidationError.params wider by [@​cm-ayf](https://togithub.com/cm-ayf) in [fastify/fastify#4476 - docs(ecosystem): add fastify-hashids by [@​andersonjoseph](https://togithub.com/andersonjoseph) in [fastify/fastify#4934 - fix: hasPlugin does not track parent plugins by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4929 - docs: early hints plugin is fastify plugin by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4947 - chore: add pull request title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4951 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.29.6 to 0.30.2 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4952 - ci: improve pr title check by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4953 - ci: fix warnings in benchmark workflows by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4954 - docs: fix removeAdditional comment by [@​G0maa](https://togithub.com/G0maa) in [fastify/fastify#4948 - fix: Try to fix parser benchmark workflow by [@​kibertoad](https://togithub.com/kibertoad) in [fastify/fastify#4956 - fix: infer correct hook handler by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4945 - fix: do not double send the response if the request is destroyed but not aborted by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4963 - chore: Bump [@​sinclair/typebox](https://togithub.com/sinclair/typebox) from 0.30.4 to 0.31.1 by [@​dependabot](https://togithub.com/dependabot) in [fastify/fastify#4973 - fix: bodyLimit must be applied on fully decoded body by [@​sergburn](https://togithub.com/sergburn) in [fastify/fastify#4969 - chore: updates [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) and [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4977 - chore: use group dependencies in dependabot by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4979 - chore: fix ci bench by [@​Eomm](https://togithub.com/Eomm) in [fastify/fastify#4983 - fix: require.cache is undefined breaks SEA by [@​climba03003](https://togithub.com/climba03003) in [fastify/fastify#4982 - ci: remove sync next wf by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4985 - docs: remove mixing ES6 and commomjs in the example by [@​thenicolau](https://togithub.com/thenicolau) in [fastify/fastify#4990 - fix: errorHandler callback should utilize TypeProvider by [@​muan](https://togithub.com/muan) in [fastify/fastify#4989 - types: add onRoute to ApplicationHookLookup by [@​Uzlopak](https://togithub.com/Uzlopak) in [fastify/fastify#4968 - chore: make tests pass on ipv4 only machine by [@​mcollina](https://togithub.com/mcollina) in [fastify/fastify#4997 - fix: Set `FastifyRequest.id` type as a string by [@​samchungy](https://togithub.com/samchungy) in [fastify/fastify#4992 ##### New Contributors - [@​G0maa](https://togithub.com/G0maa) made their first contribution in [fastify/fastify#4948 - [@​thenicolau](https://togithub.com/thenicolau) made their first contribution in [fastify/fastify#4990 - [@​muan](https://togithub.com/muan) made their first contribution in [fastify/fastify#4989 - [@​samchungy](https://togithub.com/samchungy) made their first contribution in [fastify/fastify#4992 **Full Changelog**: fastify/fastify@v4.21.0...v4.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi42OC4xIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using https://github.com/fastify/fastify-type-provider-json-schema-to-ts I noticed that the
errorHandlercallback request does not have inferred types from TypeProvider, unlike the globalsetErrorHandler.As far as I can see this being tested else where and I am not entirely sure how to add a test here. I can however add a test to
fastify-type-provider-json-schema-to-tsthough.Checklist
npm run testandnpm run benchmarkand the Code of conduct