Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use node: prefix to bypass require.cache call for builtins #5026

Merged
merged 3 commits into from Sep 10, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Sep 10, 2023

See fastify/fastify-static#407

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9cd5ec9 into main Sep 10, 2023
30 checks passed
@mcollina mcollina deleted the perf/builtins branch September 10, 2023 10:29
renovate bot added a commit to tomacheese/telcheck that referenced this pull request Sep 11, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.2` ->
`4.23.0`](https://renovatebot.com/diffs/npm/fastify/4.22.2/4.23.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.0`](https://togithub.com/fastify/fastify/releases/tag/v4.23.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.2...v4.23.0)

#### What's Changed

- test: reduce output of reqIdGenFactory.test.js by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5012
- feat: Add onListen Hook by
[@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) in
[fastify/fastify#4899
- docs(readme): avoid line breaks in documentation links by
[@&#8203;antoineneff](https://togithub.com/antoineneff) in
[fastify/fastify#5014
- chore(examples): added curly braces to conditions for consistency by
[@&#8203;turnerran](https://togithub.com/turnerran) in
[fastify/fastify#5015
- feat: access handler name add properties to req route options by
[@&#8203;cesarvspr](https://togithub.com/cesarvspr) in
[fastify/fastify#4470
- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5018
- docs: minor improvements by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5019
- chore(deps): replace tiny-lru with toad-cache by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4668
- docs(ecosystem.md): Fix wrong entry for ecosystem.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5021
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5026
- docs(typo): mistype of monkeypatch by
[@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) in
[fastify/fastify#5027
- chore: change website to .dev instead of .io by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5028
- chore: add gurgunday and uzlopak as contributors by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5029
- chore: add a citgm command to customize what we run in CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5030

#### New Contributors

- [@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) made
their first contribution in
[fastify/fastify#4899
- [@&#8203;antoineneff](https://togithub.com/antoineneff) made their
first contribution in
[fastify/fastify#5014
- [@&#8203;turnerran](https://togithub.com/turnerran) made their first
contribution in
[fastify/fastify#5015
- [@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) made their
first contribution in
[fastify/fastify#5027

**Full Changelog**:
fastify/fastify@v4.22.2...v4.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to redwoodjs/redwood that referenced this pull request Sep 12, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.2` ->
`4.23.0`](https://renovatebot.com/diffs/npm/fastify/4.22.2/4.23.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.0`](https://togithub.com/fastify/fastify/releases/tag/v4.23.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.2...v4.23.0)

##### What's Changed

- test: reduce output of reqIdGenFactory.test.js by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5012
- feat: Add onListen Hook by
[@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) in
[fastify/fastify#4899
- docs(readme): avoid line breaks in documentation links by
[@&#8203;antoineneff](https://togithub.com/antoineneff) in
[fastify/fastify#5014
- chore(examples): added curly braces to conditions for consistency by
[@&#8203;turnerran](https://togithub.com/turnerran) in
[fastify/fastify#5015
- feat: access handler name add properties to req route options by
[@&#8203;cesarvspr](https://togithub.com/cesarvspr) in
[fastify/fastify#4470
- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5018
- docs: minor improvements by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5019
- chore(deps): replace tiny-lru with toad-cache by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4668
- docs(ecosystem.md): Fix wrong entry for ecosystem.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5021
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5026
- docs(typo): mistype of monkeypatch by
[@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) in
[fastify/fastify#5027
- chore: change website to .dev instead of .io by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5028
- chore: add gurgunday and uzlopak as contributors by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5029
- chore: add a citgm command to customize what we run in CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5030

##### New Contributors

- [@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) made
their first contribution in
[fastify/fastify#4899
- [@&#8203;antoineneff](https://togithub.com/antoineneff) made their
first contribution in
[fastify/fastify#5014
- [@&#8203;turnerran](https://togithub.com/turnerran) made their first
contribution in
[fastify/fastify#5015
- [@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) made their
first contribution in
[fastify/fastify#5027

**Full Changelog**:
fastify/fastify@v4.22.2...v4.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit to redwoodjs/redwood that referenced this pull request Sep 13, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.22.2` ->
`4.23.0`](https://renovatebot.com/diffs/npm/fastify/4.22.2/4.23.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.22.2/4.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.0`](https://togithub.com/fastify/fastify/releases/tag/v4.23.0)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.22.2...v4.23.0)

##### What's Changed

- test: reduce output of reqIdGenFactory.test.js by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5012
- feat: Add onListen Hook by
[@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) in
[fastify/fastify#4899
- docs(readme): avoid line breaks in documentation links by
[@&#8203;antoineneff](https://togithub.com/antoineneff) in
[fastify/fastify#5014
- chore(examples): added curly braces to conditions for consistency by
[@&#8203;turnerran](https://togithub.com/turnerran) in
[fastify/fastify#5015
- feat: access handler name add properties to req route options by
[@&#8203;cesarvspr](https://togithub.com/cesarvspr) in
[fastify/fastify#4470
- chore: Bump the dev-dependencies group with 1 update by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[fastify/fastify#5018
- docs: minor improvements by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5019
- chore(deps): replace tiny-lru with toad-cache by
[@&#8203;kibertoad](https://togithub.com/kibertoad) in
[fastify/fastify#4668
- docs(ecosystem.md): Fix wrong entry for ecosystem.md by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5021
- perf: use `node:` prefix to bypass require.cache call for builtins by
[@&#8203;Fdawgs](https://togithub.com/Fdawgs) in
[fastify/fastify#5026
- docs(typo): mistype of monkeypatch by
[@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) in
[fastify/fastify#5027
- chore: change website to .dev instead of .io by
[@&#8203;Eomm](https://togithub.com/Eomm) in
[fastify/fastify#5028
- chore: add gurgunday and uzlopak as contributors by
[@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5029
- chore: add a citgm command to customize what we run in CITGM by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5030

##### New Contributors

- [@&#8203;BrendenInhelder](https://togithub.com/BrendenInhelder) made
their first contribution in
[fastify/fastify#4899
- [@&#8203;antoineneff](https://togithub.com/antoineneff) made their
first contribution in
[fastify/fastify#5014
- [@&#8203;turnerran](https://togithub.com/turnerran) made their first
contribution in
[fastify/fastify#5015
- [@&#8203;Menkveld-24](https://togithub.com/Menkveld-24) made their
first contribution in
[fastify/fastify#5027

**Full Changelog**:
fastify/fastify@v4.22.2...v4.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@trentm
Copy link

trentm commented Sep 18, 2023

In case it helps anyone else, this change effectively bumps fastify@4's minimum supported node v14 from v14.6.0 (details) to v14.18.0 (the first Node v14 with node:-prefixed module support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants