New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add routeOptions.config to types #5034

Merged

mcollina merged 1 commit into main from fix-types

Sep 13, 2023

Member

mcollina commented Sep 13, 2023

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
commit message and code follows the Developer's Certification of Origin
and the Code of conduct


          Add routeOptions.config to types

3f7872d

Signed-off-by: Matteo Collina <hello@matteocollina.com>

mcollina requested a review from climba03003

September 13, 2023 09:15

github-actions bot added the typescript label

mcollina requested review from Uzlopak and ivan-tymoshenko

September 13, 2023 09:16

mcollina changed the title ~~Add routeOptions.config to types~~ fix: add routeOptions.config to types

ivan-tymoshenko approved these changes

View reviewed changes

Member

ivan-tymoshenko left a comment

lgtm

Eomm approved these changes

View reviewed changes

Uzlopak approved these changes

View reviewed changes

Contributor

Uzlopak left a comment

LGTM

But we need a follow up to add schema attribute too.

mcollina merged commit 30c2dff into main

28 of 29 checks passed

mcollina deleted the fix-types branch

September 13, 2023 09:50

Uzlopak mentioned this pull request

fix: add routeOptions.schema to types #5035

Merged

4 tasks

renovate bot added a commit to tomacheese/telcheck that referenced this pull request


          chore(deps): update dependency fastify to v4.23.1 (#288)

56e1148

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.0` ->
`4.23.1`](https://renovatebot.com/diffs/npm/fastify/4.23.0/4.23.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.1`](https://togithub.com/fastify/fastify/releases/tag/v4.23.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.0...v4.23.1)

#### What's Changed

- fix: correct warnings for request.routerPath and request.routerMethod
by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5032
- fix: add routeOptions.config to types by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5034

**Full Changelog**:
fastify/fastify@v4.23.0...v4.23.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tomacheese/telcheck).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot added a commit to redwoodjs/redwood that referenced this pull request


          fix(deps): update dependency fastify to v4.23.1 (#9167)

b8ce4ef

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.0` ->
`4.23.1`](https://renovatebot.com/diffs/npm/fastify/4.23.0/4.23.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.1`](https://togithub.com/fastify/fastify/releases/tag/v4.23.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.0...v4.23.1)

##### What's Changed

- fix: correct warnings for request.routerPath and request.routerMethod
by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5032
- fix: add routeOptions.config to types by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5034

**Full Changelog**:
fastify/fastify@v4.23.0...v4.23.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>

jtoar added a commit to redwoodjs/redwood that referenced this pull request


          fix(deps): update dependency fastify to v4.23.1 (#9167)

82231fd

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [fastify](https://www.fastify.dev/)
([source](https://togithub.com/fastify/fastify)) | [`4.23.0` ->
`4.23.1`](https://renovatebot.com/diffs/npm/fastify/4.23.0/4.23.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/fastify/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/fastify/4.23.0/4.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>fastify/fastify (fastify)</summary>

###
[`v4.23.1`](https://togithub.com/fastify/fastify/releases/tag/v4.23.1)

[Compare
Source](https://togithub.com/fastify/fastify/compare/v4.23.0...v4.23.1)

##### What's Changed

- fix: correct warnings for request.routerPath and request.routerMethod
by [@&#8203;Uzlopak](https://togithub.com/Uzlopak) in
[fastify/fastify#5032
- fix: add routeOptions.config to types by
[@&#8203;mcollina](https://togithub.com/mcollina) in
[fastify/fastify#5034

**Full Changelog**:
fastify/fastify@v4.23.0...v4.23.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment