-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(async-hooks): mixing async and callback style in preHandler option now returns an error #5069
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1bba51f
fix(async-hooks): mixing async and callback style in preHandler optio…
giuliowaitforitdavide 4a62008
refactor(async-hooks-validation): moved validation in one place and c…
giuliowaitforitdavide c6e3888
style(hooks-validation): removed negated false
giuliowaitforitdavide 348dae3
28c0fac
2ae3fd3
Update lib/validation.js
giuliowaitforitdavide 1a72522
Revert "Update lib/validation.js"
giuliowaitforitdavide 7de902a
Revert "style(hooks-validation): removed negated false"
giuliowaitforitdavide 3fe7880
Revert "refactor(async-hooks-validation): moved validation in one pla…
giuliowaitforitdavide 0f0a896
perf(async-hook-validation): improved performance with simplier data …
giuliowaitforitdavide 51bc299
test(hooks-async-validation): improved coverage to 100%
giuliowaitforitdavide File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all hooks have the same parameters:
'onTimeout' - 3
'onRequest' - 3
'preParsing' - 4
'preValidation' - 3
'preSerialization' - 4
'preHandler' - 3
'onSend' - 4
'onResponse' - 3
'onError' - 4
'onRequestAbort - 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following your suggestion and the check done here I came up with a small refactor. Do you think it's worth it or should I revert it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does make sense 👍🏼
but I think we should not rewrite too much the code as the additional functions and datastructure may slowdown the start time