Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump find-may-way to v8.0.0 #5236

Merged
merged 1 commit into from
Dec 26, 2023
Merged

chore: bump find-may-way to v8.0.0 #5236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const { buildErrorHandler } = require('./error-handler')
const { createChildLogger } = require('./logger')

function buildRouting (options) {
options.config.useSemicolonDelimiter = true // To avoid a breaking change
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant we make this an options to be passed?
Solve it maybe like this?

Suggested change
options.config.useSemicolonDelimiter = true // To avoid a breaking change
options.config.useSemicolonDelimiter ?= true // To avoid a breaking change
  • typescript typings and documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently have no time to add an option with all the things that it entails (TS and docs).

This is essentially to allow us to bump to the latest version of FMW without a breaking change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho create an issue and put a good-first-issud label is enough

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

const router = FindMyWay(options.config)

let avvio
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@
"avvio": "^8.2.1",
"fast-content-type-parse": "^1.1.0",
"fast-json-stringify": "^5.8.0",
"find-my-way": "^7.7.0",
"find-my-way": "^8.0.0",
"light-my-request": "^5.11.0",
"pino": "^8.17.0",
"process-warning": "^3.0.0",
Expand Down