Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Request route options url add undefined #5307

Merged
merged 3 commits into from
Feb 9, 2024
Merged

fix(types): Request route options url add undefined #5307

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd87cb3
fix(types): Request route options url add undefined
rozzilla Feb 9, 2024
58be407
Add test
rozzilla Feb 9, 2024
4b0e236
Merge branch 'main' into fix/types/request-route-options-url-add-unde…
mcollina Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/types/request.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import pino from 'pino'
import { expectAssignable, expectType } from 'tsd'
import fastify, {
ContextConfigDefault,
Expand Down Expand Up @@ -83,6 +82,7 @@ const getHandler: RouteHandler = function (request, _reply) {
expectType<FastifySchema>(request.routeSchema)
expectType<FastifySchema>(request.routeOptions.schema)
expectType<RouteHandlerMethod>(request.routeOptions.handler)
expectType<string | undefined>(request.routeOptions.url)

expectType<RequestHeadersDefault & RawRequestDefaultExpression['headers']>(request.headers)
request.headers = {}
Expand Down
9 changes: 5 additions & 4 deletions types/request.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ export interface ValidationFunction {

export interface RequestRouteOptions<ContextConfig = ContextConfigDefault, SchemaCompiler = FastifySchema> {
method: string;
url: string;
bodyLimit:number;
attachValidation:boolean;
logLevel:string;
// `url` can be `undefined` for instance when `request.is404` is true
url: string | undefined;
bodyLimit: number;
attachValidation: boolean;
logLevel: string;
version: string | undefined;
exposeHeadRoute: boolean;
prefixTrailingSlash: string;
Expand Down