Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: benchmark CI #5414

Merged
merged 1 commit into from Apr 21, 2024
Merged

fix: benchmark CI #5414

merged 1 commit into from Apr 21, 2024

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Apr 21, 2024

We cannot only install production dependencies in these workflows as they depend on devDeps to run:

npm install --only=production --ignore-scripts

npm run --silent benchmark > ./bench-result.md

"benchmark": "concurrently -k -s first \"node ./examples/benchmark/simple.js\" \"autocannon -c 100 -d 30 -p 10 localhost:3000/\"",

fastify/package.json

Lines 155 to 170 in 13f9b6e

"devDependencies": {
"@fastify/pre-commit": "^2.0.2",
"@sinclair/typebox": "^0.31.17",
"@sinonjs/fake-timers": "^11.1.0",
"@types/node": "^20.8.4",
"@typescript-eslint/eslint-plugin": "^6.7.5",
"@typescript-eslint/parser": "^6.7.5",
"ajv": "^8.12.0",
"ajv-errors": "^3.0.0",
"ajv-formats": "^2.1.1",
"ajv-i18n": "^4.2.0",
"ajv-merge-patch": "^5.0.1",
"autocannon": "^7.14.0",
"branch-comparer": "^1.1.0",
"c8": "^8.0.1",
"concurrently": "^8.2.2",

@gurgunday gurgunday requested a review from a team April 21, 2024 09:31
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@Uzlopak Uzlopak merged commit 35a6b99 into fastify:main Apr 21, 2024
38 checks passed
@gurgunday gurgunday deleted the fix-benchmark-ci branch April 21, 2024 11:25
@gurgunday gurgunday added the github actions Github actions related label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Github actions related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants