Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove-label job uses the wrong repo #5415

Merged
merged 5 commits into from Apr 21, 2024
Merged

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Apr 21, 2024

Another issue discovered in the CI, remove-label jobs are failing due wrong information being sent to the REST API:

https://github.com/fastify/fastify/actions/runs/8772362238/job/24071203586?pr=5413#step:2:13
https://github.com/fastify/fastify/actions/runs/8772362236/job/24071226346?pr=5413#step:2:13

I believe it's choosing the wrong repo, it should be the base repo instead of the owner of the PR's repo

Reference: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

@gurgunday gurgunday changed the title Fix ending fix: remove-label uses the wrong repo Apr 21, 2024
@gurgunday gurgunday changed the title fix: remove-label uses the wrong repo fix: remove-label job uses the wrong repo Apr 21, 2024
@gurgunday gurgunday requested review from Uzlopak and a team April 21, 2024 12:08
@Eomm Eomm added the github actions Github actions related label Apr 21, 2024
@gurgunday
Copy link
Member Author

@Eomm ok, from 404 - Not found to 403 - Resource not accessible by integration

@gurgunday gurgunday removed the github actions Github actions related label Apr 21, 2024
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess

@gurgunday gurgunday added the github actions Github actions related label Apr 21, 2024
@Uzlopak Uzlopak merged commit c47b033 into fastify:main Apr 21, 2024
45 of 46 checks passed
@gurgunday gurgunday deleted the fix-ending branch April 21, 2024 15:21
@gurgunday
Copy link
Member Author

Why is citgm remove-label still running 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Github actions related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants