Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable request logging #5435

Merged
merged 10 commits into from May 2, 2024
Merged

feat: disable request logging #5435

merged 10 commits into from May 2, 2024

Conversation

SamSalvatico
Copy link
Contributor

@SamSalvatico SamSalvatico commented Apr 30, 2024 •
edited

feat for issue: #5409

Check for the disableRequestLogging to be false or undefined before logging an error or a 404 during the request

Checklist

@Uzlopak Uzlopak changed the title Fix: [#5409] disable request logging fix: disable request logging Apr 30, 2024
metcoder95
metcoder95 reviewed May 1, 2024
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Tho, I'm over the fence of considering this as a fix as was never stated that this was supported; I'd rather consider it more an enhancement.

Sadly tests are failing.

@SamSalvatico SamSalvatico changed the title fix: disable request logging feat: disable request logging May 2, 2024
metcoder95
metcoder95 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metcoder95
Copy link
Member

Forgot to mention, can we add some documentation of this within the disableRequestLogging option documentation?

mcollina
mcollina approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey ho lets go.

Uzlopak
Uzlopak reviewed May 2, 2024
View reviewed changes
docs/Reference/Server.md Outdated Show resolved Hide resolved
Uzlopak
Uzlopak requested changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Uzlopak
Uzlopak approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go

@mcollina mcollina merged commit f2835db into fastify:main May 2, 2024
37 checks passed
@SamSalvatico SamSalvatico deleted the fix/5409-disable-request-logging branch May 3, 2024 05:22
@metcoder95 metcoder95 linked an issue May 3, 2024 that may be closed by this pull request
disableRequestLogging should disable logs in default error handler #5409
Closed
2 tasks
@metcoder95 metcoder95 mentioned this pull request May 3, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disableRequestLogging should disable logs in default error handler
4 participants
@SamSalvatico @metcoder95 @mcollina @Uzlopak