Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused dependency and fix ci #5454

Merged
merged 1 commit into from May 9, 2024
Merged

chore: remove unused dependency and fix ci #5454

merged 1 commit into from May 9, 2024

Conversation

gurgunday
Copy link
Member

Removed in f776447

@gurgunday
Copy link
Member Author

Will test the benchmark label too

@gurgunday gurgunday added the benchmark Label to run benchmark against PR and main branch label May 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Node: 18
PR: [1] 1314k requests in 30.04s, 247 MB read
MAIN: [1] 1390k requests in 30.04s, 261 MB read

Node: 20
PR: [1] 1345k requests in 30.04s, 253 MB read
MAIN: [1] 1370k requests in 30.04s, 257 MB read

Node: 22
PR: [1] 1477k requests in 30.04s, 277 MB read
MAIN: [1] 1442k requests in 30.04s, 271 MB read

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Node: 18
PR: [1] 1490k requests in 30.04s, 280 MB read
MAIN: [1] 1522k requests in 30.04s, 286 MB read

Node: 20
PR: [1] 1510k requests in 30.05s, 284 MB read
MAIN: [1] 1516k requests in 30.05s, 285 MB read

Node: 22
PR: [1] 1479k requests in 30.04s, 278 MB read
MAIN: [1] 1520k requests in 30.04s, 286 MB read

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label May 8, 2024
gurgunday
gurgunday commented May 8, 2024
View reviewed changes
fastify.js
@@ -1,6 +1,6 @@
'use strict'

const VERSION = '5.0.0-dev'
const VERSION = '5.0.0-alpha.1'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix CI

@gurgunday gurgunday changed the title chore: remove unused dependency chore: remove unused dependency and fix ci May 8, 2024
@gurgunday gurgunday requested a review from mcollina May 8, 2024 22:21
@Eomm Eomm merged commit 0bf9506 into fastify:main May 9, 2024
48 checks passed
@gurgunday gurgunday deleted the remove-dep branch May 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@Eomm Eomm Eomm approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gurgunday @Uzlopak @metcoder95 @Eomm