feat: request and reply decorators can not be a reference type #5462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
added
v5.x
mcollina
requested changes
May 12, 2024
lib/decorate.js
Outdated
| if (typeof fn === 'object' && fn && !(typeof fn.getter === 'function' || typeof fn.setter === 'function')) { | ||
| FSTDEP006(name) | ||
| return encapsulatedDecorator(fn) |
There was a problem hiding this comment.
I would just throw in this case and not clone.
There was a problem hiding this comment.
So are we removing the warning to replace it with an error while suggesting the user use the getter/setter interface?
github-actions
bot
added
documentation
Eomm
changed the title
mcollina
approved these changes
May 19, 2024
metcoder95
approved these changes
May 19, 2024
Eomm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2598
This PR replaces the WARN message with an error when a reference type is used as a request or reply decorator, suggesting using a different API.
To use a reference type as a decorator without sharing values across requests, the user must use the
getter/setterinterface or thehookapproach. Both methods are documented with examples.This PR has been sponsored by Nearform
Checklist
npm run testandnpm run benchmarkand the Code of conduct