migrate to class #271
Open
migrate to class #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Oct 30, 2023
Comment on lines
+177
to
+182
| // TODO change this to use the header getter | ||
| const regex = new RegExp('\\r\\n' + name + ': ([^\\r]*)\\r\\n') | ||
| const [, value] = this._header.match(regex) || [] | ||
| // const value = this.getHeader(name) | ||
| if (value) { | ||
| this._lightMyRequest.headers[name.toLowerCase()] = value |
There was a problem hiding this comment.
will the unit tests pass if you use the header getter?
There was a problem hiding this comment.
What do you mean, this function is same as original
There was a problem hiding this comment.
Do not pass, these headers 'Data', 'Connection', 'Transfer-Encoding' do not exist
|
@jsumners, Can you explain your negative attitude? |
|
@jsumners I'm not mentioning bun in this PR (since not all issues are resolved) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate to class syntax (Chain, request, response)
copied class from #252
but without changing the logic in
lib/do-inject.js(doInject) (to resolve Test Fastify Integration)Checklist
npm run testandnpm run benchmarkand the Code of conduct