Extend TS interface for route specific options #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is very minor, it just extends the type definition for a feature implemented in #284 and thus fixes #332
I'm not a TS expert, so I'm happy for any input on this.
One minor point though: I'm not sure about tests. They are kind of broken for TS part right now and I fixed some small things (like mismatch in the engines / templates / extensions), but it is not possible, at least with
ejs
, to have one server serving both an application with a global template and an application with a route specific template, because these are mutually exclusive.Another minor thing: in the template for
index-with-no-data
, there are some values specified, which are not optional forejs
. I can fix this, but I would like to discuss first how the fix should look like (e.g. running two fastify servers on different ports, one with global layout, one with local layout, updating templates accordingly or adding new ones etc.).Checklist
npm run test
andnpm run benchmark
and the Code of conduct