Notify slack about a new tester signing up #134
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
plaetzchen
force-pushed
the
slack_webhook
branch
from
e64e784
to
0d02d17
Compare
|
CLAs look good, thanks! |
|
Also tested on Heroku with our live app. Works for me. |
There was a problem hiding this comment.
I'm in the process of a rather large refactor which will introduce the idea of a "service" that contains business logic, so I think these changes can go in that file. You can see my current PR here: #135
Once it is merged, let me know if you need any help. Great job here!
| @@ -1,4 +1,5 @@ | |||
| require 'spaceship' | |||
| require 'slack-notifier' | |||
There was a problem hiding this comment.
let's add the slack-notifier gem to the gem file too 😄
| @@ -92,6 +93,7 @@ def submit | |||
| logger.info "Addding tester to application" | |||
| app.default_external_group.add_tester!(tester) | |||
| logger.info "Done" | |||
| notify_slack(first_name,last_name,email) | |||
There was a problem hiding this comment.
tiny minor nit, lets get spaces after the ',' for the args
| @@ -187,4 +189,13 @@ def testing_is_live? | |||
| end | |||
| return false | |||
| end | |||
|
|
|||
| def notify_slack(first_name,last_name,email) | |||
There was a problem hiding this comment.
same here: spaces after the ',' for the args
|
Any update on this? |
|
@nickdima Are you still interested in merge this? If so, can you make the requested changes and rebase? 🙃 |
|
I think I should do this and I will. Sorry, totally forgot about this |
|
@plaetzchen No problem! Was just curious 🙃 Lemme know if you need any help or anything 💪 |
|
I would love for this to submit to mailchimp too |
|
@taquitos Got time to fix these conflicts? |
I really like the idea of getting a slack notification of a new tester signing up (see #20 ) so I implemented it.
Note: I am not a ruby developer by profession so please check if this is a good idea. Tested on local though