Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in "best practices" pages #1219

Merged
merged 2 commits into from Oct 21, 2023
Merged

fix typos in "best practices" pages #1219

merged 2 commits into from Oct 21, 2023

Conversation

thapasusheel
Copy link
Contributor

This PR fix the typo that has been seen in various files.

distrbution > distribution
practies > practise
managment > management
unque > unique
configuraiton > configuration

rogerluan
rogerluan reviewed Oct 20, 2023
View reviewed changes
docs/generated/actions/appstore.md Outdated Show resolved Hide resolved
docs/generated/available-plugins.md Outdated
@@ -2763,7 +2763,7 @@ Auto generated, please only modify https://github.com/fastlane/fastlane/blob/mas

<p class="via-text">via Jiří Otáhal</p>

> Automated version managment and generator of release notes.
> Automated version management and generator of release notes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this and all files under /generated/ and /plugins/ directories

@rogerluan
Copy link
Member

Thanks for noticing these and taking the initiative to fix them @thapasusheel ! 🤗

Out of the changes you made, all of them except 1 belong to the main fastlane repo, could you adjust this PR? I'll fix the typos in the main repo meanwhile :)

@rogerluan rogerluan mentioned this pull request Oct 20, 2023
Merged
@rogerluan
Copy link
Member

I addressed all I could here: fastlane/fastlane#21589

@rogerluan rogerluan changed the title Chore : Fix typo in multiple files fix typo in codemagic page Oct 20, 2023
@thapasusheel
Copy link
Contributor Author

@rogerluan Can you review it again?

rogerluan
rogerluan requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thapasusheel not sure if you pushed any changes? The PR looks the same to me 🤔

To be clear, only the changes made to codemagic.md are to be kept, the others should be reverted as they're autogenerated 🙏

Thanks in advance!

@thapasusheel
Copy link
Contributor Author

@rogerluan I have updated as per you have said. Can you review it again?

@rogerluan rogerluan changed the title fix typo in codemagic page fix typos in "best practices" pages Oct 21, 2023
rogerluan
rogerluan approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 thanks for your contributions @thapasusheel !

@rogerluan rogerluan merged commit 45d3bf6 into fastlane:master Oct 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbrasna janbrasna janbrasna left review comments

@rogerluan rogerluan rogerluan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thapasusheel @rogerluan @janbrasna