[match] fix: make git_private_key path absolute (#21360)

match/lib/match/storage/git_storage.rb

@@ -59,12 +59,20 @@ def initialize(type: nil,
         self.clone_branch_directly = clone_branch_directly
         self.git_basic_authorization = git_basic_authorization
         self.git_bearer_authorization = git_bearer_authorization
-        self.git_private_key = git_private_key
+        self.git_private_key = convert_private_key_path_to_absolute(git_private_key)
 
         self.type = type if type
         self.platform = platform if platform
       end
 
+      def convert_private_key_path_to_absolute(git_private_key)
+        if !git_private_key.nil? && File.file?(File.expand_path(git_private_key))
+          File.expand_path(git_private_key).shellescape.to_s
+        else
+          git_private_key
+        end
+      end
+
       def prefixed_working_directory
         return working_directory
       end

match/spec/storage/git_storage_spec.rb

@@ -157,7 +157,7 @@
       it "wraps the git command in ssh-agent shell when using a private key file" do
         path = Dir.mktmpdir # to have access to the actual path
         expect(Dir).to receive(:mktmpdir).and_return(path)
-        expect(File).to receive(:file?).and_return(true)
+        expect(File).to receive(:file?).twice.and_return(true)
         git_url = "https://github.com/fastlane/fastlane/tree/master/certificates"
         shallow_clone = false
         private_key = "#{path}/fastlane.match.id_dsa"
@@ -194,7 +194,7 @@
       it "wraps the git command in ssh-agent shell when using a raw private key" do
         path = Dir.mktmpdir # to have access to the actual path
         expect(Dir).to receive(:mktmpdir).and_return(path)
-        expect(File).to receive(:file?).and_return(false)
+        expect(File).to receive(:file?).twice.and_return(false)
         git_url = "https://github.com/fastlane/fastlane/tree/master/certificates"
         shallow_clone = false
         private_key = "-----BEGIN PRIVATE KEY-----\n-----END PRIVATE KEY-----\n"