Skip to content

Commit

Permalink
Remove unused parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
lacostej committed Dec 13, 2023
1 parent c3a2343 commit ad4bcbc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion frameit/lib/frameit/editor.rb
Expand Up @@ -439,7 +439,7 @@ def build_text_images(max_width, max_height)

results[key] = text_image

# Natively trimming the image with .trim will result in the loss of the common baseline between the text in all images when side-by-side (e.g. stack_title is false).
# Natively trimming the image with .trim will result in the loss of the common baseline between the text in all images when side-by-side.
# Hence retrieve the calculated trim bounding box without actually trimming:
calculated_trim_box = text_image.identify do |b|
b.format("%@") # CALCULATED: trim bounding box (without actually trimming), see: http://www.imagemagick.org/script/escape.php
Expand Down
4 changes: 2 additions & 2 deletions snapshot/lib/snapshot/setup.rb
Expand Up @@ -19,7 +19,7 @@ def self.create(path, is_swift_fastfile: false, print_instructions_on_failure: f

if File.exist?(snapfile_path)
if print_instructions_on_failure
print_instructions(snapshot_helper_filename: snapshot_helper_filename, snapfile_path: snapfile_path)
print_instructions(snapshot_helper_filename: snapshot_helper_filename)
return
else
UI.user_error!("Snapfile already exists at path '#{snapfile_path}'. Run 'fastlane snapshot' to generate screenshots.")
Expand All @@ -37,7 +37,7 @@ def self.create(path, is_swift_fastfile: false, print_instructions_on_failure: f
print_instructions(snapshot_helper_filename: snapshot_helper_filename, snapfile_path: snapfile_path)
end

def self.print_instructions(snapshot_helper_filename: nil, snapfile_path: nil)
def self.print_instructions(snapshot_helper_filename: nil)
puts("Open your Xcode project and make sure to do the following:".yellow)
puts("1) Add a new UI Test target to your project".yellow)
puts("2) Add the ./fastlane/#{snapshot_helper_filename} to your UI Test target".yellow)
Expand Down

0 comments on commit ad4bcbc

Please sign in to comment.