[scan] fix misleading error message when no devices are found (#21650)

fastlane · Nov 27, 2023 · d334e2f · d334e2f
1 parent 2860bac
commit d334e2f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/scan/lib/scan/detect_values.rb b/scan/lib/scan/detect_values.rb
@@ -146,6 +146,8 @@ def self.detect_simulator(devices, requested_os_type, deployment_target_key, def
 
           selector = ->(sim) { pieces.count > 0 && sim.name == pieces.first }
 
+          display_device = "'#{device_string}'"
+
           set + (
             if pieces.count == 0
               [] # empty array
@@ -157,6 +159,8 @@ def self.detect_simulator(devices, requested_os_type, deployment_target_key, def
                 .pop(1)
             else # pieces.count == 2 -- mathematically, because of the 'end of line' part of our regular expression
               version = pieces[1].tr('()', '')
+              display_device = "'#{pieces[0]}' with version #{version}"
+
               potential_emptiness_error = lambda do |sims|
                 if sims.empty?
                   UI.error("No simulators found that are equal to the version " \
@@ -168,8 +172,8 @@ def self.detect_simulator(devices, requested_os_type, deployment_target_key, def
             end
           ).tap do |array|
             if array.empty?
-              UI.test_failure!("No device found with name '#{device_string}'") if Scan.config[:ensure_devices_found]
-              UI.error("Ignoring '#{device_string}', couldn’t find matching simulator")
+              UI.test_failure!("No device found with name #{display_device}") if Scan.config[:ensure_devices_found]
+              UI.error("Ignoring '#{device_string}', couldn't find matching simulator")
             end
           end
         end