Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] update deliver/runner.rb to handle both ipa and pkg paths. #20043

Merged
merged 6 commits into from Jun 29, 2022
Merged

[deliver] update deliver/runner.rb to handle both ipa and pkg paths. #20043

merged 6 commits into from Jun 29, 2022

Conversation

snatchev
Copy link
Member

@snatchev snatchev commented Mar 9, 2022

See #19659 for rationale.

@krzysiek84 krzysiek84 mentioned this pull request Apr 8, 2022
Closed
@snatchev snatchev marked this pull request as ready for review May 19, 2022 13:19
@snatchev snatchev requested a review from joshdholtz May 24, 2022 13:44
krzysiek84
krzysiek84 reviewed May 26, 2022
View reviewed changes
Copy link
Contributor

@krzysiek84 krzysiek84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

crazymanish
crazymanish approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! 🚀

@crazymanish crazymanish changed the title Update deliver/runner.rb to handle both ipa and pkg paths. [deliver] update deliver/runner.rb to handle both ipa and pkg paths. Jun 28, 2022
@joshdholtz
Copy link
Member

@snatchev Added a commit to update that verify_binary method to use the same logic!

@snatchev snatchev merged commit 019bad7 into master Jun 29, 2022
@snatchev snatchev deleted the snatchev-patch-1 branch June 29, 2022 06:04
@snatchev
Copy link
Member Author

@joshdholtz great! Thanks so much!

@fastlane-bot
Copy link

Hey @snatchev 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@joshdholtz joshdholtz mentioned this pull request Jun 30, 2022
Merged
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krzysiek84 krzysiek84 krzysiek84 left review comments

@crazymanish crazymanish crazymanish approved these changes

@joshdholtz joshdholtz Awaiting requested review from joshdholtz

Assignees
No one assigned
Labels
status: released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snatchev @joshdholtz @fastlane-bot @krzysiek84 @crazymanish