New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon #21493
[trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon #21493
Conversation
…check for it speficially
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix, @TheMetalCode ! 🙏
I'd normally try to figure out what is causing this value to be nil, but it might genuinely be just a different behavior of the new Xcode 15, when run specifically on Apple Silicon.
I'm personally facing this issue in CircleCI Xcode 15 Apple Silicon and think this is a valid fix.
I wish we had unit tests to cover this case, could you look into adding tests to cover this scenario @TheMetalCode ? 🙏 Also, looks like CI is failing in this PR
@rogerluan Will add tests and address CI, hope to get to that this evening. |
@rogerluan @joshdholtz this PR fixes a crash against the GA version of Xcode 15, could you take a look when you have a moment? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 thanks for fixing this
Excellent! When might we expect a new release? |
Hard to tell for sure, but I think soon enough! Meanwhile you can point your fastlane gem to master to use this 🙏 |
Does this fix the issue described in #21295 ? |
I don't think so...? Why do you think they're related @geoff-sheldon-bfg ? |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21475
Description
It would appear that with Xcode 15 there are at least some cases where test failure data would not include a
url
property. Adjusting the check infailure_message
to specifically verify the presence ofself.document_location_in_creating_workspace&.url
prior to attempting to append it to the failure message seems liek the most straightforward resolution.Testing Steps