Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon #21493

Merged

Conversation

TheMetalCode
Copy link
Contributor

@TheMetalCode TheMetalCode commented Aug 30, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21475

Description

It would appear that with Xcode 15 there are at least some cases where test failure data would not include a url property. Adjusting the check in failure_message to specifically verify the presence of self.document_location_in_creating_workspace&.url prior to attempting to append it to the failure message seems liek the most straightforward resolution.

Testing Steps

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @TheMetalCode ! 🙏

I'd normally try to figure out what is causing this value to be nil, but it might genuinely be just a different behavior of the new Xcode 15, when run specifically on Apple Silicon.

I'm personally facing this issue in CircleCI Xcode 15 Apple Silicon and think this is a valid fix.

I wish we had unit tests to cover this case, could you look into adding tests to cover this scenario @TheMetalCode ? 🙏 Also, looks like CI is failing in this PR

@rogerluan rogerluan changed the title [trainer] Check Specifically for file url in failure_message [trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon Sep 25, 2023
@TheMetalCode
Copy link
Contributor Author

@rogerluan Will add tests and address CI, hope to get to that this evening.

@jszumski
Copy link
Contributor

jszumski commented Oct 5, 2023

@rogerluan @joshdholtz this PR fixes a crash against the GA version of Xcode 15, could you take a look when you have a moment? Thanks!

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 thanks for fixing this

@rogerluan rogerluan merged commit 1732b60 into fastlane:master Oct 9, 2023
10 checks passed
@raid5
Copy link

raid5 commented Oct 9, 2023

Excellent! When might we expect a new release?

@rogerluan
Copy link
Member

Hard to tell for sure, but I think soon enough! Meanwhile you can point your fastlane gem to master to use this 🙏

@geoff-sheldon-bfg
Copy link

Does this fix the issue described in #21295 ?

@rogerluan
Copy link
Member

I don't think so...? Why do you think they're related @geoff-sheldon-bfg ?

mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Oct 31, 2023
mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Nov 6, 2023
mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Nov 19, 2023
mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Nov 23, 2023
mokagio added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer not working with Xcode 15 beta 6
5 participants