Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon #21493

Merged
merged 9 commits into from Oct 9, 2023
Merged

[trainer] check specifically for file url in failure_message, fixing crash in Xcode 15 when running in Apple Silicon #21493

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fc27df8
Since url is the property we're trying to append to failure message, …
TheMetalCode Aug 30, 2023
9850ce9
Merge remote-tracking branch 'origin/master' into jjh/fix-trainer-xco…
TheMetalCode Aug 30, 2023
c175dd4
Merge remote-tracking branch 'origin/master' into jjh/fix-trainer-xco…
TheMetalCode Sep 18, 2023
f3cfb16
Merge remote-tracking branch 'origin/master' into jjh/fix-trainer-xco…
TheMetalCode Sep 20, 2023
b6eef94
Add test to verify we still get useful test failure data without docu…
TheMetalCode Sep 25, 2023
0ce7a1e
We don't like the dig here, message received
TheMetalCode Sep 25, 2023
57fa2cf
ping
TheMetalCode Sep 25, 2023
3d21c3b
clean up mock
TheMetalCode Sep 26, 2023
37f555a
ping for ci
TheMetalCode Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion trainer/lib/trainer/xcresult.rb
View file
Open in desktop
Expand Up @@ -391,7 +391,7 @@ def initialize(data)

def failure_message
new_message = self.message
if self.document_location_in_creating_workspace
if self.document_location_in_creating_workspace&.url
file_path = self.document_location_in_creating_workspace.url.gsub("file://", "")
new_message += " (#{file_path})"
end
Expand Down