Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] Capturing NoMethodError exception when fetching live app info #21553

Conversation

kronenthaler
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

The recent commit c4ed1a42 throws an error if a field is missing.

Description

In some cases, the app info might be missing some fields and the execution throws an error

Testing Steps

N/A

@getaaron
Copy link
Collaborator

getaaron commented Oct 6, 2023

@kronenthaler Thanks for the PR! I see you checked

I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)

but I don't see that the ci/circleci builds have ran — can you please double check you're signed into CircleCI with your GitHub credentials and try pushing another commit?

@kronenthaler
Copy link
Contributor Author

@getaaron done, the build seems to report one single check, but the pipeline in circleci has multiple steps.

@getaaron getaaron merged commit b7714db into fastlane:master Oct 7, 2023
3 checks passed
@getaaron
Copy link
Collaborator

getaaron commented Oct 7, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants