Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] Capturing NoMethodError exception when fetching live app info #21553

Merged
merged 2 commits into from Oct 7, 2023
Merged

[deliver] Capturing NoMethodError exception when fetching live app info #21553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d775bde
capturing NoMethodError exception
kronenthaler Oct 5, 2023
9a07bb0
force retrigger circleci build
kronenthaler Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion deliver/lib/deliver/upload_metadata.rb
View file
Open in desktop
Expand Up @@ -484,7 +484,11 @@ def updating_localized_app_info?(options, app, app_info)
app_info_locale = localizations.find { |l| l.locale == language }
next if app_info_locale.nil?

current_value = app_info_locale.public_send(key.to_sym)
begin
current_value = app_info_locale.public_send(key.to_sym)
rescue NoMethodError
next
end

return true if current_value != strip_value
end
Expand Down