Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastlane.swift] fix Unexpected duplicate tasks error message in Fastlane Swift #21621

Merged
merged 1 commit into from Dec 14, 2023

Conversation

mollyIV
Copy link
Member

@mollyIV mollyIV commented Nov 8, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #20104

Description

As mentioned in #20104 (comment), the issue is about having two build phases that copy FastlaneRunner target.

To fix this problem, we added additional logic to check if Copy Files build phase already contains FastlaneRunner target. If it does, we will not add redundant FastlaneRunnerCopySigned build phase.

The change is additive to be extra safe to not break anything. However, it'd be nice to understand the reasoning behind original decision in favour of "FastlaneRunnerCopySigned" introduction and clean up / adjust code based accordingly.

Testing Steps

Steps to test:

  • initialize fastlane Swift in iOS project via fastlane init swift
  • execute bundle exec fastlane customLane
  • answer YES to "Should we try to upgrade just your FastlaneSwiftRunner project?" question
  • validate if there's no error anymore
  • open FastlaneSwiftRunner and check if there's no "FastlaneRunnerCopySigned" phase in Build Phases
Screenshot 2023-11-08 at 13 05 56 Screenshot 2023-11-08 at 13 06 53

Tested on Xcode 15, macOS Sonoma 14.0.

Thank you 🙇

@joshdholtz joshdholtz changed the title Fix Unexpected duplicate tasks error message in Fastlane Swift [Fastlane.swift] fix Unexpected duplicate tasks error message in Fastlane Swift Nov 10, 2023
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyyy, its good to see you again 😊

This looks good to me! I don't know the history of this file. I believe that would be @taquitos if he is able to look at it 🤷‍♂️

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well :) Thanks for the PR!

@lacostej lacostej merged commit dc0c66c into master Dec 14, 2023
6 checks passed
@lacostej lacostej deleted the fix-swift-unexpected-duplicate-tasks branch December 14, 2023 19:26
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any lane failing with code 65 (error: Unexpected duplicate tasks)
3 participants