[Fastlane.swift] fix Unexpected duplicate tasks error message in Fastlane Swift #21621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #20104
Description
As mentioned in #20104 (comment), the issue is about having two build phases that copy
FastlaneRunner
target.To fix this problem, we added additional logic to check if
Copy Files
build phase already containsFastlaneRunner
target. If it does, we will not add redundantFastlaneRunnerCopySigned
build phase.The change is additive to be extra safe to not break anything. However, it'd be nice to understand the reasoning behind original decision in favour of "FastlaneRunnerCopySigned" introduction and clean up / adjust code based accordingly.
Testing Steps
Steps to test:
fastlane
Swift in iOS project viafastlane init swift
bundle exec fastlane customLane
FastlaneSwiftRunner
project?" questionFastlaneSwiftRunner
and check if there's no "FastlaneRunnerCopySigned" phase in Build PhasesTested on Xcode 15, macOS Sonoma 14.0.
Thank you 🙇