[deliver][spaceship][scan] fix build warnings in rspec #21660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
fix/build_warnings
branch
from
f1fc587
to
7ddd032
Compare
lacostej
force-pushed
the
fix/build_warnings
branch
from
7ddd032
to
6e0ee4b
Compare
lacostej
force-pushed
the
fix/build_warnings
branch
from
6e0ee4b
to
8a0a740
Compare
lacostej
force-pushed
the
fix/build_warnings
branch
from
78acb96
to
4b651ad
Compare
rogerluan
approved these changes
Nov 24, 2023
| @@ -1,5 +1,12 @@ | |||
| describe Spaceship::Tunes::DeviceType do | |||
| describe "type identifiers" do | |||
| before(:each) do | |||
| # let's catch those calls to avoid polluting the output | |||
| # Note: warning has a different signature in newer versions of ruby | |||
There was a problem hiding this comment.
Is this the reason why we have 2 allow calls? If so, can we specify this in the comment? I think it'd be more clear, like:
Suggested change
| # Note: warning has a different signature in newer versions of ruby | |
| # Note: warnings have different signature depending on the Ruby version, hence why we need more than one allow(…) |
There was a problem hiding this comment.
I made an update.
rogerluan
changed the title
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
* Remove 'warning: already initialized constant ScreenSize' * Remove warning of rspec raise_error being used too widely * Remove warning related to rspec around usage * Reduce amount of deprecation output. * Remove chruby as we are not installing it. Is it needed? * Rubocop fix * Update spaceship/spec/tunes/device_type_spec.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> * Clean comment --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build output is cluttered with unecessary error messages. Removing some of them.
WIP
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps