Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver][spaceship][scan] fix build warnings in rspec #21660

Merged
merged 8 commits into from Nov 24, 2023
Merged

[deliver][spaceship][scan] fix build warnings in rspec #21660

merged 8 commits into from Nov 24, 2023

Commits on Nov 22, 2023

  1. Remove 'warning: already initialized constant ScreenSize'

    @lacostej
    lacostej committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d0472a0 View commit details
    Browse the repository at this point in the history

  2. Remove warning of rspec raise_error being used too widely

    @lacostej
    lacostej committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7e17125 View commit details
    Browse the repository at this point in the history

  3. Remove warning related to rspec around usage

    @lacostej
    lacostej committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    15654ef View commit details
    Browse the repository at this point in the history

  4. Reduce amount of deprecation output.

    @lacostej
    lacostej committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    56c0438 View commit details
    Browse the repository at this point in the history

  5. Remove chruby as we are not installing it. Is it needed?

    @lacostej
    lacostej committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8a0a740 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Rubocop fix

    @lacostej
    lacostej committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4b651ad View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Update spaceship/spec/tunes/device_type_spec.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    baae833 View commit details
    Browse the repository at this point in the history

  2. Clean comment

    @lacostej
    lacostej committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    1dda3d9 View commit details
    Browse the repository at this point in the history