Remove some unused method parameters #21722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
changed the title
rogerluan
approved these changes
Dec 13, 2023
lacostej
force-pushed
the
fix/rubocop_unused_params
branch
from
7a61ea2
to
ad4bcbc
Compare
lacostej
force-pushed
the
fix/rubocop_unused_params
branch
from
ad4bcbc
to
2fd836e
Compare
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
* Reformat code for readability * Remove unused env parameter in cruise_lane calls * Remove unused parameter * Remove unused parameter * Remove unused parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a first pass at running rubocop on unused method parameters and found these. Also a little code indentation cleanup.
All changes are in individual commits.
More improvements on the same topic coming later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps