Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sigh] fix cache parameters validation #21766

Merged

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Jan 3, 2024

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Regression issue comment.

Description

Lift restrictions on cache_* parameters for sigh.

Testing Steps

@nekrich nekrich changed the title fix: sigh cache validation parameters [sigh] fix cache parameters validation Jan 3, 2024
@nekrich nekrich marked this pull request as ready for review January 3, 2024 13:43
@nekrich
Copy link
Contributor Author

nekrich commented Jan 3, 2024

@joshdholtz , sorry for the ping. Please review and release #21767 and #21766 since regression impacts many folks?

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshdholtz joshdholtz merged commit 5ca4eb7 into fastlane:master Jan 4, 2024
2 checks passed
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
* fix: sigh cache validation parameters

* fix: needs_profiles_devices resoling in portal cache

* chore: fix nil devices and certificates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants