-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] support fetching build_bundle_file_sizes
for a BuildBundle
#20860
Merged
joshdholtz
merged 4 commits into
fastlane:master
from
liamnichols:ln/build_bundle_file_sizes
Nov 16, 2022
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f0f9833
Add BuildBundleFileSizes model and update testlight client to support…
liamnichols d6667e2
Add BuildBundle.build_bundle_file_sizes helper
liamnichols 5786256
Add test coverage
liamnichols b0968df
Rename get_build_bundle_build_bundle_file_sizes -> get_build_bundles_…
liamnichols File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
spaceship/lib/spaceship/connect_api/models/build_bundle_file_sizes.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
require_relative '../model' | ||
module Spaceship | ||
class ConnectAPI | ||
class BuildBundleFileSizes | ||
include Spaceship::ConnectAPI::Model | ||
|
||
attr_accessor :device_model | ||
attr_accessor :os_version | ||
attr_accessor :download_bytes | ||
attr_accessor :install_bytes | ||
|
||
attr_mapping({ | ||
"deviceModel" => "device_model", | ||
"osVersion" => "os_version", | ||
"downloadBytes" => "download_bytes", | ||
"installBytes" => "install_bytes" | ||
}) | ||
|
||
def self.type | ||
return "buildBundleFileSizes" | ||
end | ||
|
||
# | ||
# API | ||
# | ||
|
||
def self.all(client: nil, build_bundle_id: nil, limit: 30) | ||
client ||= Spaceship::ConnectAPI | ||
resps = client.get_build_bundle_build_bundle_file_sizes(build_bundle_id: build_bundle_id).all_pages | ||
resps.flat_map(&:to_models) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I in the right place? Is the TestFlight client the right place to implement this kind of thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This client names are a little bit weird since App Store Connect API has changed a bit since this was create 🙈 But yup! This would be the correct place for this 💪