Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] add the iPhone 14 devices for the HTML report page #20951

Closed
wants to merge 1 commit into from

Conversation

crazymanish
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

  • add the iPhone 14 devices for the HTML report page

Screenshot

Screenshot 2022-12-26 at 11 16 54

@isandeepj
Copy link
Contributor

isandeepj commented Feb 15, 2023

@cbowns , @kommen , @lsegal

Can you please review this PR and merge it because we are facing the issue on HTML report generating due to all iPhone 14 devices name is not found.

Thanks

@kadaggers
Copy link

Wanted to bump this PR as this support would be super helpful for the designers on my team as they can't easily look over all of our screenshots for iPhone 14 due to this limitation.

@kenji21
Copy link

kenji21 commented Jul 19, 2023

As the screen name is determined using the filename part after the first dash:

screen_name = file_name.sub(key_name + '-', '').sub('.png', '')

I think a more robust/durable fix is to remove the available_devices list, and get the device name as it is done in SnapshotHelper.swift :

let path = screenshotsDir.appendingPathComponent("\(simulator)-\(name).png")

@micke-b
Copy link

micke-b commented Aug 10, 2023

I need this as well. Please review and merge. 👍

@getaaron
Copy link
Collaborator

getaaron commented Oct 6, 2023

This was addressed in #21554 so I'm closing this PR. Thank you for sending it in anyway and apologies for not getting to this sooner.

@getaaron getaaron closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iPhone 14 models missing in report
6 participants