Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports #21225

Closed
wants to merge 3 commits into from

Conversation

kylehowells
Copy link
Contributor

@kylehowells kylehowells commented Apr 22, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

I noticed running snapshot with only the iPhone 14 selected that the generated screenshots file was blank. I worked out the list of supported devices for the report is hardcoded, so have updated the list of devices.

Description

Added missing recent iPhone simulator names to the definitions used to output generated HTML files

Updated to match the Xcode Version 14.3 simulator names.

Screenshot 2023-04-22 at 04 54 56

@kylehowells kylehowells changed the title [snapshot] Add missing newer iPhone models to Generated Snapshot Reports [snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports Apr 22, 2023
@kylehowells
Copy link
Contributor Author

Updated the PR to add the missing iPad names as well as the originally added iPhone names

@getaaron
Copy link
Collaborator

getaaron commented Oct 6, 2023

Thanks for the PR, @kylehowells - I believe this is addressed now as part of #21554 so I'm closing this PR. Apologies for not getting to it sooner.

@getaaron getaaron closed this Oct 6, 2023
@kylehowells
Copy link
Contributor Author

@getaaron thanks for the reply. I checked the new PR and it looks like the newer PR still misses some of the older iPhones and iPads this PR was adding support for, as it was mostly just adding the new devices for this year.

I'll double check those older phones are still in Xcode 15 and update the PR/create a new one.

I originally created this PR not because I wanted to test new phones that weren't supported, but because I was trying to setup screenshot testing on older phones we mostly ignore and won't notice UI issues with, and found they weren't added on here at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants