Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fastlane action template warnings reported by Rubocop #21310

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Fix fastlane action template warnings reported by Rubocop #21310

merged 5 commits into from
Jul 4, 2023

Commits on May 30, 2023

  1. Fix Style/StringLiterals RuboCap warning 

    More information about warning:
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/StringLiterals
    @bartoszkosiorek
    bartoszkosiorek committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d235ab4 View commit details
    Browse the repository at this point in the history

  2. Fix indentation of template Action, reported by Rubocop 

    https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/IndentationWidth
    @bartoszkosiorek
    bartoszkosiorek committed May 30, 2023
    Configuration menu
    Copy the full SHA
    4b0bd6f View commit details
    Browse the repository at this point in the history

  3. Fix Layout/LineLength: Line is too long, reported by Rubocop 

    More information:
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/LineLength
    @bartoszkosiorek
    bartoszkosiorek committed May 30, 2023
    Configuration menu
    Copy the full SHA
    166bb33 View commit details
    Browse the repository at this point in the history

  4. Fix Style/MethodCallWithArgsParentheses reported by Rubocop

    @bartoszkosiorek
    bartoszkosiorek committed May 30, 2023
    Configuration menu
    Copy the full SHA
    6350616 View commit details
    Browse the repository at this point in the history

  5. Fix Style/ParenthesesAroundCondition, Style/AndOr and Style/Not 

    Fixes:
* Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an unless.
* Style/AndOr: Use && instead of and.
* Style/Not: Use ! instead of not.
    @bartoszkosiorek
    bartoszkosiorek committed May 30, 2023
    Configuration menu
    Copy the full SHA
    74e721a View commit details
    Browse the repository at this point in the history