Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] fetch live app info if no edit info is present, fixing scenario of having both macOS and iOS apps present #21472

Merged
merged 21 commits into from Sep 29, 2023
Merged

[deliver] fetch live app info if no edit info is present, fixing scenario of having both macOS and iOS apps present #21472

merged 21 commits into from Sep 29, 2023

Commits on Aug 25, 2023

  1. Fetch live app info if no edit info is present

    @loremattei
    loremattei authored and Lorenzo Mattei committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c976e9a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Add comments to explain the fallback

    @loremattei
    loremattei authored and Lorenzo Mattei committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    23ea7c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Check App Info localization only when new metadata contains App Info

    @loremattei
    loremattei authored and Lorenzo Mattei committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    9453b77 View commit details
    Browse the repository at this point in the history

  2. Fix lint issues

    @loremattei
    loremattei authored and Lorenzo Mattei committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d57b974 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Only fail upload when trying to update localised app info in no edit … 

    …mode.
    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    d62af0d View commit details
    Browse the repository at this point in the history

  2. Update tests

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    7d42af5 View commit details
    Browse the repository at this point in the history

  3. Make rubocop happy

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c1bdd94 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Update deliver/lib/deliver/upload_metadata.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @loremattei @rogerluan
    loremattei and rogerluan committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    f5187ff View commit details
    Browse the repository at this point in the history

  2. Update deliver/lib/deliver/upload_metadata.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @loremattei @rogerluan
    loremattei and rogerluan committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    dfbf80d View commit details
    Browse the repository at this point in the history

  3. Update deliver/lib/deliver/upload_metadata.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @loremattei @rogerluan
    loremattei and rogerluan committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    d04fb08 View commit details
    Browse the repository at this point in the history

  4. Update message severity

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    aae5bdd View commit details
    Browse the repository at this point in the history

  5. Minimize api call to fetch app infos

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    5c161ef View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Add tests

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    66470dc View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Fix simple typos.

    @rogerluan
    rogerluan committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e016f01 View commit details
    Browse the repository at this point in the history

  2. Refactor to more Ruby-like syntax 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @loremattei @rogerluan
    loremattei and rogerluan committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    896c292 View commit details
    Browse the repository at this point in the history

  3. Update tests

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    89086aa View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Update spelling for consistency 

    Co-authored-by: Olivier Halligon <olivier@halligon.net>
    @loremattei @AliSoftware
    loremattei and AliSoftware committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    52bbce7 View commit details
    Browse the repository at this point in the history

  2. Update spelling for consistency 

    Co-authored-by: Olivier Halligon <olivier@halligon.net>
    @loremattei @AliSoftware
    loremattei and AliSoftware committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    09f89e3 View commit details
    Browse the repository at this point in the history

  3. Address feedback

    @loremattei
    loremattei authored and Lorenzo Mattei committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    104ecdb View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Update user-facing message.

    @rogerluan
    rogerluan committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0cc2bfc View commit details
    Browse the repository at this point in the history

  2. Fix syntax of string quotes.

    @rogerluan
    rogerluan committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0e62085 View commit details
    Browse the repository at this point in the history