New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fastlane-core] recommends to retry uploading when AltoolTransporterExecutor crashes #21536
Merged
lacostej
merged 9 commits into
fastlane:master
from
TheMetalCode:jjh/ensure-pty-returns-exit-code
Dec 14, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ef599cc
Force FastlanePty.spawn to return exit code if it ends up being nil f…
TheMetalCode 8def462
Actually, let's implement the fix right where the problem occurs, and…
TheMetalCode 3d5d917
Update fastlane_core/lib/fastlane_core/itunes_transporter.rb
TheMetalCode 8dd005c
Merge remote-tracking branch 'origin/master' into jjh/ensure-pty-retu…
TheMetalCode f0c2247
Merge branch 'jjh/ensure-pty-returns-exit-code' of github.com:TheMeta…
TheMetalCode fb9237f
Merge remote-tracking branch 'origin/master' into jjh/ensure-pty-retu…
TheMetalCode 3fb4124
Merge remote-tracking branch 'origin/master' into jjh/ensure-pty-retu…
TheMetalCode 6dc2c3a
Remove unneeded nil catch given #21618
TheMetalCode 8ce5919
Write more accurate test
TheMetalCode File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems safe, it makes testing the specific error line we're adding for the
-1
return more straightforward