Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for keyword arguments for lanes in Ruby 3 #21587

Merged
merged 8 commits into from Oct 19, 2023
Merged

Add support for keyword arguments for lanes in Ruby 3 #21587

merged 8 commits into from Oct 19, 2023

Commits on Oct 19, 2023

  1. Add tests for lanes using keyword parameters

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1381e1a View commit details
    Browse the repository at this point in the history

  2. Support keyword parameters in lanes in Ruby 3 

    While that previously worked implicitly in Ruby 2.x (with our internal implementation always passing a `Hash` in `lane.call(…)` but Ruby converting it as keywords dynamically if the block expected keywords), this has to be explicit in Ruby 3.x now.

See https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6891acc View commit details
    Browse the repository at this point in the history

  3. Support Windows using a different error message format

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    932dccd View commit details
    Browse the repository at this point in the history

  4. Fix CI Linux failures and rubocop violations

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    66fe9be View commit details
    Browse the repository at this point in the history

  5. Slightly improve code comment

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    4e4efb2 View commit details
    Browse the repository at this point in the history

  6. Slightly tweak unit tests and fix typos

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5f8356c View commit details
    Browse the repository at this point in the history

  7. Improve test description 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @AliSoftware @rogerluan
    AliSoftware and rogerluan committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    919ba4f View commit details
    Browse the repository at this point in the history

  8. Add test cases for passing nil to keyword parameters

    @AliSoftware
    AliSoftware committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    944909f View commit details
    Browse the repository at this point in the history