Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let FastlanePty detect when externally invoked programs crash, harden it when using popen, and expose process statuses. #21618

Merged
merged 8 commits into from Nov 17, 2023
Merged

Let FastlanePty detect when externally invoked programs crash, harden it when using popen, and expose process statuses. #21618

merged 8 commits into from Nov 17, 2023

Commits on Nov 6, 2023

  1. Add Tests for FastlanePty

    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    57043e8 View commit details
    Browse the repository at this point in the history

  2. Fix tests to work on all platforms, and add a test showing up an issu… 

    …e in the code
    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e31a1d1 View commit details
    Browse the repository at this point in the history

  3. Make sure exception in blocks in the case of popen command execution … 

    …are wrapped properly
    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    216e7ea View commit details
    Browse the repository at this point in the history

  4. Remove unused code

    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    82674c8 View commit details
    Browse the repository at this point in the history

  5. Make sure we get the status from the right variable in the case of popen

    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a358ad3 View commit details
    Browse the repository at this point in the history

  6. Add an implementation to catch crashes and convert them to FastlanePt… 

    …yError with a -1 error code
    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7bb4130 View commit details
    Browse the repository at this point in the history

  7. A helper C program used to investigate ruby behavior

    @lacostej
    lacostej committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5b3ae4e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Adjust code after code review

    @lacostej
    lacostej committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    bfe3ae1 View commit details
    Browse the repository at this point in the history