Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][spm] add simulator flag for swift compiler #21707

Merged
merged 17 commits into from Dec 19, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 29 additions & 4 deletions fastlane/lib/fastlane/actions/spm.rb
Expand Up @@ -11,11 +11,14 @@ def self.run(params)
cmd << "--disable-sandbox" if params[:disable_sandbox]
cmd << "--verbose" if params[:verbose]
if params[:simulator]
_simulator_platform = simulator_platform(simulator: params[:simulator], simulator_arch: params[:simulator_arch])
_simulator_sdk = simulator_sdk(simulator: params[:simulator])
_simulator_sdk_suffix = simulator_sdk_suffix(simulator: params[:simulator])
simulator_flags = [
"-Xswiftc", "-sdk",
"-Xswiftc", "$(xcrun --sdk #{params[:simulator]} --show-sdk-path)",
"-Xswiftc", "-target",
"-Xswiftc", "#{params[:simulator_arch] || "arm64"}-apple-#{params[:simulator] == "iphonesimulator" ? 'ios' : 'macosx'}$(xcrun --sdk #{params[:simulator]} --show-sdk-version | cut -d '.' -f 1)#{"-simulator" if params[:simulator] == "iphonesimulator"}"
"-Xswiftc", "#{_simulator_platform}#{_simulator_sdk}#{_simulator_sdk_suffix}"
]
cmd += simulator_flags
end
Expand Down Expand Up @@ -113,11 +116,12 @@ def self.available_options
end),
FastlaneCore::ConfigItem.new(key: :simulator_arch,
env_name: "FL_SPM_SIMULATOR_ARCH",
description: "Specifies the architecture of the simulator to pass for Swift Compiler (one of: #{valid_architectures.join(', ')}), requires simulator to be specified also",
description: "Specifies the architecture of the simulator to pass for Swift Compiler (one of: #{valid_architectures.join(', ')}). Requires the simulator option to be specified also, otherwise, it's ignored",
type: String,
optional: true,
optional: false,
default_value: "arm64",
verify_block: proc do |value|
UI.user_error!("Please pass a valid simulator architecrure. Use one of the following: #{valid_architectures.join(', ')}") unless valid_architectures.include?(value)
UI.user_error!("Please pass a valid simulator architecture. Use one of the following: #{valid_architectures.join(', ')}") unless valid_architectures.include?(value)
end)
]
end
Expand All @@ -141,6 +145,13 @@ def self.example_code
'spm(
command: "generate-xcodeproj",
xcconfig: "Package.xcconfig"
)',
'spm(
simulator: "iphonesimulator"
)',
'spm(
simulator: "macosx",
simulator_arch: "arm64"
)'
]
end
Expand Down Expand Up @@ -172,6 +183,20 @@ def self.valid_simulators
def self.valid_architectures
%w(x86_64 arm64)
end

def self.simulator_platform(params)
platform_suffix = "#{params[:simulator] == "iphonesimulator" ? 'ios' : 'macosx'}"
gharary marked this conversation as resolved.
Show resolved Hide resolved
"#{params[:simulator_arch]}-apple-#{platform_suffix}"
end

def self.simulator_sdk(params)
"$(xcrun --sdk #{params[:simulator]} --show-sdk-version | cut -d '.' -f 1)"
end

def self.simulator_sdk_suffix(params)
return "" unless params[:simulator] == "iphonesimulator"
"-simulator"
end
end
end
end