[ci] fix linter issues that slipped to master due to CI issue #21747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
AliSoftware
approved these changes
Dec 20, 2023
|
Note that once again, CircleCI didn't run on this PR. In fact I tried but couldn't find the head branch of this PR when I tried filtering to find it in CircleCI… |
|
It won't run @AliSoftware , it doesn't include the fix from the other PR #21746. We have to merge this one in first (I made all the checks locally and attached screenshots in the PR description), and I'll rebase the other PR to include these changes to make sure everything checks out :) |
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
…ne#21747) * Fix linter issue that slipped to master, and simplify string declaration. * Fix syntax issue in example code caught by docs validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validI see several greenci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This PR fixes these issues:
Which got introduced when we merged #21707 after CircleCI was broken in #21735
Description
Simple lint fix with an added improvement to avoid unnecessary string interpolation.
Testing Steps
This PR won't have the CircleCI checks (e.g. linter) until #21746 is merged, and #21746 won't be mergeable until this PR gets merged because it will fail lint. Cyclic dependency :P let's just get this one merged, which's quite safe, so we can evaluate #21746 after.
Here's proof I tested this:
bundle exec rubocopbundle exec fastlane validate_docsbundle exec rspec