Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sigh] prevent crashes in fetch_profiles when profiles have no bundle_id #21758

Merged
merged 1 commit into from Jan 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sigh/lib/sigh/runner.rb
Expand Up @@ -91,7 +91,7 @@ def fetch_profiles
results = Sigh.config[:cached_profiles]
results ||= Spaceship::ConnectAPI::Profile.all(filter: filter, includes: includes)
results.select! do |profile|
profile.bundle_id.identifier == Sigh.config[:app_identifier]
profile.bundle_id&.identifier == Sigh.config[:app_identifier]
end

results = results.find_all do |current_profile|
Expand Down