Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add Xcode 15.2 to the suite of tests and remove duplicate CircleCI test environment #21811

Merged
merged 1 commit into from Jan 17, 2024

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Jan 16, 2024

The cleanups in #21777 revealed/caused a duplicate environment in circle. So let's add a more modern one and remove the duplicate.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

Testing Steps

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's an issue with the new one being added 😅 is this a CI issue, or it also doesn't pass locally @lacostej ? I'll retrigger to see if this is not juts flakiness

@rogerluan rogerluan changed the title [ci] Readjust circle environments as we had a duplicate one [ci] remove duplicate CircleCI test environment and add Xcode 15.2 to the suite of tests Jan 17, 2024
@rogerluan rogerluan changed the title [ci] remove duplicate CircleCI test environment and add Xcode 15.2 to the suite of tests [ci] add Xcode 15.2 to the suite of tests and remove duplicate CircleCI test environment Jan 17, 2024
@lacostej
Copy link
Collaborator Author

Apparently there's an issue with the new one being added 😅 is this a CI issue, or it also doesn't pass locally @lacostej ? I'll retrigger to see if this is not juts flakiness

no it's just #21792 the flaky test. We can merge.

@rogerluan rogerluan merged commit cef5a1e into fastlane:master Jan 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants