sinonjs#2226: Rename util

fatso83 · Mar 9, 2020 · 170c99a · 170c99a
1 parent 07a8f8c
commit 170c99a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 11 deletions.
diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -6,7 +6,7 @@ var behaviors = require("./default-behaviors");
 var createProxy = require("./proxy");
 var functionName = require("@sinonjs/commons").functionName;
 var hasOwnProperty = require("@sinonjs/commons").prototypes.object.hasOwnProperty;
-var isNonExistentOwnProperty = require("./util/core/is-non-existent-own-property");
+var isNonExistentProperty = require("./util/core/is-non-existent-property");
 var spy = require("./spy");
 var extend = require("./util/core/extend");
 var getPropertyDescriptor = require("./util/core/get-property-descriptor");
@@ -69,8 +69,8 @@ function stub(object, property) {
 
     throwOnFalsyObject.apply(null, arguments);
 
-    if (isNonExistentOwnProperty(object, property)) {
-        throw new TypeError("Cannot stub non-existent own property " + valueToString(property));
+    if (isNonExistentProperty(object, property)) {
+        throw new TypeError("Cannot stub non-existent property " + valueToString(property));
     }
 
     var actualDescriptor = getPropertyDescriptor(object, property);

diff --git a/lib/sinon/util/core/is-non-existent-own-property.js b/lib/sinon/util/core/is-non-existent-own-property.js
diff --git a/lib/sinon/util/core/is-non-existent-property.js b/lib/sinon/util/core/is-non-existent-property.js
@@ -0,0 +1,12 @@
+"use strict";
+
+/**
+ * @param {*} object
+ * @param {String} property
+ * @returns whether a prop exists in the prototype chain
+ */
+function isNonExistentProperty(object, property) {
+    return object && typeof property !== "undefined" && !(property in object);
+}
+
+module.exports = isNonExistentProperty;
diff --git a/test/sandbox-test.js b/test/sandbox-test.js
@@ -562,7 +562,7 @@ describe("Sandbox", function() {
                     function() {
                         sandbox.stub(object, Symbol());
                     },
-                    { message: "Cannot stub non-existent own property Symbol()" },
+                    { message: "Cannot stub non-existent property Symbol()" },
                     TypeError
                 );