Fix sinonjs#2226: restoring non-configurable props on prototype chain

fatso83 · Mar 9, 2020 · 350178b · 350178b
1 parent 4adf2c2
commit 350178b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/sinon/default-behaviors.js b/lib/sinon/default-behaviors.js
@@ -258,7 +258,7 @@ var defaultBehaviors = {
         Object.defineProperty(rootStub.rootObj, rootStub.propName, {
             value: newVal,
             enumerable: true,
-            configurable: isPropertyConfigurable(rootStub.rootObj, rootStub.propName)
+            configurable: rootStub.shadowsPropOnPrototype || isPropertyConfigurable(rootStub.rootObj, rootStub.propName)
         });
 
         return fake;

diff --git a/lib/sinon/stub.js b/lib/sinon/stub.js
@@ -94,11 +94,14 @@ function stub(object, property) {
     var func = typeof actualDescriptor.value === "function" ? actualDescriptor.value : null;
     var s = createStub(func);
 
+    var propIsOwn = Boolean(actualDescriptor.isOwn);
+
     extend.nonEnum(s, {
         rootObj: object,
         propName: property,
+        shadowsPropOnPrototype: !propIsOwn,
         restore: function restore() {
-            if (actualDescriptor !== undefined) {
+            if (actualDescriptor !== undefined && propIsOwn) {
                 Object.defineProperty(object, property, actualDescriptor);
                 return;
             }